Do not reload table schema when update catalog cache (#2667) #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
zhangyangyu
approved these changes
Apr 26, 2023
xuanyu66
approved these changes
Apr 26, 2023
|
/run-all-tests |
|
/run-all-tests |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 0c036cb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2667
What problem does this PR solve?
TiSpark will reload all table schemas when init catalogCache. It will also reload all table schemas once we call listTable or getTable with the invalid cache.
One user reports that TiSpark hangs with more than 10000+ table schemas.
What is changed and how it works?
Add a configuration
spark.tispark.load_tables, default is true.when set it to false, we will not load all tables when we reload the cache. table cache will only be loaded when the table is used.
Check List
Tests